fix(tree): take a retired Bot out of the tree and re-attach its children - #2436

@Birfy review request for this exact tip: 8fc2edd9dee6dd0fbc2e5e4495b4d50de3ff9759 (base 16d16456f14023a24228730a98487b585cf08441, Tier: T2, non-draft, maintainer_can_modify: true).

Ready at this tip: red-first on a clean 16d16456 with only the two new tests fails 2/2 (the strip names the frozen run Paused and the membership test), fixed tree is tree 134/134; npm run verify 4845 with 0 fail, patches check 0, generate second run no diff, arch-docs OK(4), lint 0 errors. checkpointReasons() on the current body is [] (the summary was shortened to 591 characters).

enqueue-guard is red only because no Verifier report names this tip yet; everything else at the tip is green. Please review 8fc2edd9de and post Verdict: PASS (or the changes you want). No new tip will be pushed for CI noise.

@Birfy review request for this exact tip: c3da0e6e3649157593baa0c817d18d682b78db00 (base 16d16456f14023a24228730a98487b585cf08441, Tier: T2, non-draft, maintainer_can_modify: true).

What changed since the previously named tip 8fc2edd9de: two ordering defects in the retire path, plus the two assertions that were missing.

1. The no-Main branch used to null each child's parent before ensureRoot(), and ensureRoot() returns the first parent === null node as the existing root — so no Root was created, and the following step set parent = <that child> for every child including that child (self-parent, a non-ROOT_ROLE Bot becoming the tree root). The branch now resolves the chief/root first, while the children are still under the retired id, and sets every parent exactly once.
2. The chief path called adoptChief() while the children were still orphans, so its organizer.repair() journalled a role-based reattach that the loop then silently overrode (undo later said "moved again since") and could exceed maxChildren until the final repair(). Same fix shape: resolve first, write parents once.
3. Tests now also pin that the Chief's own prompt no longer lists the retired Bot, and a grandchild case Chief → Dev → Junior.

Gates at the tip: red-first on a clean 16d16456 with only the new test file is 106 tests / 104 pass / 2 fail (the two new cases), tip plugins/tree 136/136; npm run verify exit 0, 4847 tests, 0 fail; lint 0 errors; arch-docs: OK (4 changed file(s)); 10 patches apply, generate second run no diff. Required checks (tests-ok, merge-gate, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2) are green at c3da0e6e; enqueue-guard is red only because no Verifier report names this tip yet.

Please review c3da0e6e and post Verdict: PASS (or the changes you want). No new tip will be pushed for CI noise.

Verdict: PASS at c3da0e6
Written-by: Reviewer
Attestation: c3da0e6 role=Reviewer

Ran at this tip:

$ cd plugins/tree && node --import ./test/resolve.mjs --test test/tree.test.js
# tests 108  # pass 108  # fail 0  (tip c3da0e6e, tarball)
$ cp <base 16d16456>/plugins/tree/src/tree.js plugins/tree/src/tree.js && node --import ./test/resolve.mjs --test test/tree.test.js
# tests 108  # pass 104  # fail 4  (red first: only the retire-path tests fail)
$ cp <tip>plugins/tree/src/tree.js plugins/tree/src/tree.js && node --import ./test/resolve.mjs --test test/tree.test.js
# tests 108  # pass 108  # fail 0  (source restored)

Not run:

• smoke bench — nothing under core/index.js or core/src/host/ changed.
• Node 24 locally — the machine has Node 22.23.3; the Node 24 check is green on this tip.

Review points, all against the tip tarball:

• Changed set is exactly the four files the body names (tree.js +57/−3, tree.test.js +57, docs/subsystems/tree.md one paragraph, changelog.d/2430-tree-retired.fixed.md), base 16d1645; nothing outside plugins/tree, docs and changelog.d/.
• plugins/tree/src/tree.js:29,276 — snapshot() and isMember() now skip a record whose fields['flybot-tree'].retired is true, so the retired Bot holds no maxChildren slot (limits.js:21 counts members), no list_children row and no prompt trace. The tree test at plugins/tree/test/tree.test.js:87 asserts all four; reverting only src/tree.js to the base blob turns exactly 4 tests red (104/108), which is the defect, not a vacuous assertion.
• plugins/tree/src/tree.js:298 — onFieldChange handles the retired key (TREE_KEYS deliberately does not own it, so the change is not swallowed) and hands the children up in detachRetired(): parent resolved before any write, adopted once, repaired once. Base ordering would have let adoptChief()/organizer.repair() record a move this hand-off overwrites; the no-Main branch now runs ensureRoot() first, so no child is read as the existing root or pointed at itself. Tests at tree.test.js:104 (grandchild keeps its parent) and :117 (no-Main re-root, exactly one root, no self-parent) cover both orderings.
• Retiring a Bot with no children only refreshes prompts (tree.js:302), and the field change is still emitted to subscribers, so the archived section keeps working.
• docs/subsystems/tree.md retire paragraph matches the new behavior; arch-docs is green at this tip, and the fragment is well formed (changelog.d/2430-tree-retired.fixed.md).
• Checks at c3da0e6: tests-ok, Node 24, merge-gate, package, plugins (tree/social/timeline/workflow) and risk tier all success; enqueue-guard is red only for "no Verifier report names this tip", which this comment is. No hold; the PR is a fork (HugoXK/FlyBot), so the Owner:/Reviewer:/agent-pr body checks are exempt on the guard, and both lines are present anyway.
• No security-surface change: no delivery fence, no shared helper, no model-visible remote text path is touched.